Test Codex inline review detection - #32
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
The change introduces a functional regression in scripts/ci/mtr.sh: command-line arguments are discarded, contradicting the wrapper’s documented interface and preventing targeted MTR runs. Please restore argument forwarding with "$@".
Warning
Firewall blocked 1 domain
The following domain was blocked by the firewall during workflow execution:
ab.chatgpt.com
To allow these domains, add them to the network.allowed list in your workflow frontmatter:
network:
allowed:
- defaults
- "ab.chatgpt.com"See Network Configuration for more information.
Generated by Codex PR Review for #32 · codex · gpt56 · 3.91 AIC · ⌖ 2.19 AIC · ⊞ 18.6K
Comment /codex to run again
| cd "$BUILD_DIR/mysql-test" | ||
|
|
||
| exec ./mtr "$@" | ||
| exec ./mtr |
There was a problem hiding this comment.
This drops every argument supplied to the wrapper, despite the usage text promising that scripts/ci/mtr.sh --suite=innodb ... passes raw args to ./mtr. Any CI or developer invocation that selects suites, tests, or other MTR options will silently run the default selection instead. Please retain "$@" here.
73ee812 to
0c06b42
Compare
github-actions
Bot
added
Build Passed
0c06b42 to
9a561c7
Compare
github-actions
Bot
added
Build Passed
There was a problem hiding this comment.
The existing unresolved inline finding remains valid: scripts/ci/mtr.sh now discards every caller-supplied MTR argument, so suite/test selection and other options silently stop working. Restore exec ./mtr "$@". No additional findings.
Warning
Firewall blocked 1 domain
The following domain was blocked by the firewall during workflow execution:
ab.chatgpt.com
To allow these domains, add them to the network.allowed list in your workflow frontmatter:
network:
allowed:
- defaults
- "ab.chatgpt.com"See Network Configuration for more information.
Generated by Codex PR Review for #32 · codex · gpt56 · 19.2 AIC · ⌖ 11.1 AIC · ⊞ 12.1K
Comment /codex to run again
9a561c7 to
59f9bb3
Compare
github-actions
Bot
added
Build Passed
59f9bb3 to
a72ca83
Compare
There was a problem hiding this comment.
One correctness defect remains: [P2] Restore argument forwarding in scripts/ci/mtr.sh:12. Removing "$@" silently discards suite/test selections and all other MTR options. For example, the documented scripts/ci/mtr.sh --suite=innodb invocation now launches ./mtr with no arguments. Restore exec ./mtr "$@". This is already covered by the existing unresolved inline comment, so I have not duplicated it.
No additional findings in the single-line change. Validation was static only: no local checkout was available, code search was rate-limited, and build/MTR checks were still running.
Warning
Firewall blocked 1 domain
The following domain was blocked by the firewall during workflow execution:
ab.chatgpt.com
To allow these domains, add them to the network.allowed list in your workflow frontmatter:
network:
allowed:
- defaults
- "ab.chatgpt.com"See Network Configuration for more information.
Generated by Codex PR Review for #32 · codex · gpt60 · 49.7 AIC · ⌖ 23.1 AIC · ⊞ 13.3K
Comment /codex to run again
|
/codex |
1 similar comment
|
/codex |
|
✅ Codex PR Review completed successfully! Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
To allow these domains, add them to the network:
allowed:
- defaults
- "ab.chatgpt.com"See Network Configuration for more information.
|
There was a problem hiding this comment.
One correctness issue remains at scripts/ci/mtr.sh:12: [P2] Restore argument forwarding. Removing "$@" silently discards every caller-supplied option and test name. For example, the documented scripts/ci/mtr.sh --suite=innodb invocation now starts MTR with no arguments, so it runs the default selection instead of the requested suite. Restore exec ./mtr "$@".
This is already covered by the existing inline finding; no duplicate inline comment added. Reviewed the complete one-line diff and wrapper at a72ca833; MTR was not run because no local checkout/build is available.
Warning
Firewall blocked 1 domain
The following domain was blocked by the firewall during workflow execution:
ab.chatgpt.com
To allow these domains, add them to the network.allowed list in your workflow frontmatter:
network:
allowed:
- defaults
- "ab.chatgpt.com"See Network Configuration for more information.
Generated by Codex PR Review for #32 · codex · gpt60 · 46.8 AIC · ⌖ 23.1 AIC · ⊞ 13.3K
Comment /codex to run again
a72ca83 to
0442492
Compare
github-actions
Bot
added
Build Passed
1 participant
Test-only PR for the Codex review workflow. It intentionally drops MTR argument forwarding so the reviewer has a concrete, changed-line regression to identify. Do not merge.